-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing logging for metrics at 'debug' level #1108
Add missing logging for metrics at 'debug' level #1108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 198 198
Lines 14171 14172 +1
=======================================
+ Hits 12251 12252 +1
Misses 1468 1468
Partials 452 452
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Unify API Span Start/End Options Replace both with `SpanOption`. Add a unified `SpanConfig` to match and a `SpanConfigure` function to parse a `SpanConfig` from `SpanOption`s. Update all the related options to use new `SpanOption`s. * No non-zero SpanConfig defaults The SDK uses an internal clock for the current time that cannot be use if it does not know the time has not been set. * Append attributes for WithAttributes This preserves existing behavior. * Add unit test for SpanConfigure * Propagate changes * Update append option documentation * Update testing comments * Move comments on guarantees to appropriate function * Add documentation for SDK methods Include SDK implementation specific information in the Tracer Start method and Span End method. * Add changes to Changelog * Apply suggestions from code review Co-authored-by: ET <evantorrie@users.noreply.github.com> * Update the SpanKind comment in the SpanConfig Try for a less tautological comment. Co-authored-by: ET <evantorrie@users.noreply.github.com>
Description:
Fixing a bug - enable metrics' debug logging in Logging Exporter
Link to tracking Issue: Fixes #1107
Testing:
Manual testing: simply run a collector with
--log-level=DEBUG
and the following config:The log now includes detailed information at the
DEBUG
level:Documentation: N/A