[configauth] Fix unmarshaling of confighttp.AuthConfig #10749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Jul 30, 2024
mx-psi
approved these changes
Jul 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10749 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 403 403
Lines 18812 18812
=======================================
Hits 17320 17320
Misses 1132 1132
Partials 360 360 ☔ View full report in Codecov by Sentry. |
songy23
pushed a commit
to songy23/opentelemetry-service
that referenced
this pull request
Jul 30, 2024
…y#10749) #### Description - Uses `mapstructure:",squash"` instead of `mapstructure:"-"` for the Authenticator field - Removes pointer (since pointers can't be squashed) - Adds test in OTLP receiver for this reproducing the user's issue <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#10750 --------- Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
songy23
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mapstructure:",squash"instead ofmapstructure:"-"for the Authenticator fieldLink to tracking issue
Fixes #10750