[chore] correctly escape . characters during release preparation #10631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
atoulme
approved these changes
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10631 +/- ##
==========================================
- Coverage 92.36% 92.30% -0.07%
==========================================
Files 386 397 +11
Lines 18400 18705 +305
==========================================
+ Hits 16995 17265 +270
- Misses 1052 1080 +28
- Partials 353 360 +7 ☔ View full report in Codecov by Sentry. |
|
Can we get the results of a test run of this script before merging it? |
|
Here is the output from my test VM Some notes:
Here is the console output: Console Output |
|
here's also a sample screenshot from the diff of one of the release preparation commits that happened locally: |
|
Awesome, thanks!! I think this should be safe to merge then |
|
cool! thx for merging! |
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 22, 2024
) #### Description This PR fixes an issue where the `.` character in a version string (e.g. `1.2.3`) was interpreted by `sed` as any character and therefore needed to be properly escaped. This happened during the prepare-release workflow. The version string for the current stable and current beta version strings provided at pipeline start is replaced as follows: ``` 1.2.3 -> 1[.]2[.]3 ``` This ensures that `sed` searches for the literal `.` character instead of interpreting it as a wildcard character. I specifically used the `[]` syntax to avoid the hassle of "how many backslashes do i need until it's properly escaped?". (and that for bash and sed, which work different on different OSes anyways which makes it hard to test as well) #### Link to tracking issue Fixes #23981 #### Notes This PR uses the same solution as done in open-telemetry/opentelemetry-collector#10631 to fix the same issue in that repo. Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
.character in a version string (e.g.1.2.3) was interpreted bysedas any character and therefore needed to be properly escaped. This happened during the prepare-release workflow.The version string for the current stable and current beta version strings provided at pipeline start is replaced as follows:
This ensures that
sedsearches for the literal.character instead of interpreting it as a wildcard character.I specifically used the
[]syntax to avoid the hassle of "how many backslashes do i need until it's properly escaped?". (and that for bash and sed, which work different on different OSes anyways which makes it hard to test as well)Link to tracking issue
Fixes #9748