Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] use macos-14 for arm testing #10540

Merged

Conversation

codeboten
Copy link
Contributor

Similar to open-telemetry/opentelemetry-collector-contrib#33921

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and bogdandrutu July 4, 2024 17:32
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (18e78af) to head (099131b).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10540      +/-   ##
==========================================
- Coverage   92.39%   92.26%   -0.13%     
==========================================
  Files         393      395       +2     
  Lines       18614    18703      +89     
==========================================
+ Hits        17199    17257      +58     
- Misses       1058     1086      +28     
- Partials      357      360       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten closed this Jul 4, 2024
@codeboten codeboten reopened this Jul 4, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 8, 2024

I think after this change what we claim on https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/platform-support.md#tier-2--secondary-support is no longer correct. But realistically, the current arm runners do not provide good test coverage, they are too flaky, so maybe we can just downgrade our support for Linux ARM for now

@codeboten
Copy link
Contributor Author

I think after this change what we claim on https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/platform-support.md#tier-2--secondary-support is no longer correct. But realistically, the current arm runners do not provide good test coverage, they are too flaky, so maybe we can just downgrade our support for Linux ARM for now

Pinging @atoulme for review on this as well since he's the owner of linux/arm

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
Copy link
Contributor Author

@mx-psi as per your suggestion, i've updated the supported platforms doc to reflect this change

@codeboten codeboten merged commit 6fcebdb into open-telemetry:main Jul 12, 2024
50 checks passed
@codeboten codeboten deleted the codeboten/use-macos14-for-arm branch July 12, 2024 18:59
@github-actions github-actions bot added this to the next release milestone Jul 12, 2024
@atoulme
Copy link
Contributor

atoulme commented Jul 12, 2024

I am acknowledging this change. I didn't get a chance to review and weigh in. I will take further actions to bring back support of linux/arm64 back to tier 2. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants