Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[From 3474]: Remove defaultcomponents from core (probably make it internal for tests). #3927

Closed
bogdandrutu opened this issue Aug 30, 2021 · 9 comments
Closed

[From 3474]: Remove defaultcomponents from core (probably make it internal for tests). #3927

bogdandrutu opened this issue Aug 30, 2021 · 9 comments
Assignees
@alolita @JamesJHPark
Labels
area:internal easy Complexity: Easy

Comments

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu added this to the Milestone-core-rc-release milestone Aug 30, 2021
@alolita
Copy link
Member

alolita commented Sep 2, 2021

@alexperez52 can you take a look and file a PR? ty!

@alolita alolita added area:internal release:required-for-ga Must be resolved before GA release easy Complexity: Easy labels Sep 2, 2021
@alexperez52
Copy link
Contributor

@alexperez52 can you take a look and file a PR? ty!

Gladly !

@JamesJHPark
Copy link
Contributor

@alolita - Please assign me this issue

@alolita
Copy link
Member

alolita commented Sep 8, 2021

Hi @JamesJHPark assigned!

@alolita alolita added release:required-for-ga Must be resolved before GA release and removed release:required-for-ga Must be resolved before GA release labels Sep 13, 2021
@JamesJHPark JamesJHPark mentioned this issue Sep 21, 2021
Merged
@alolita
Copy link
Member

alolita commented Dec 16, 2021

Completed.

@alolita alolita closed this as completed Dec 16, 2021
@bogdandrutu bogdandrutu reopened this Dec 17, 2021
@bogdandrutu
Copy link
Member Author

@alolita this is not completed, there are still usages of the defaultcomponents package in contrib, and the package still exists. Please help finishing this.

@bogdandrutu bogdandrutu mentioned this issue Dec 17, 2021
Merged
@alolita
Copy link
Member

alolita commented Dec 18, 2021

@JamesJHPark can you take a look?

hdost added a commit to hdost/opentelemetry-collector-releases that referenced this issue Dec 18, 2021
@hdost
Explicitly Mention Core Components
0cf8951 
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927
hdost added a commit to hdost/opentelemetry-collector-releases that referenced this issue Dec 18, 2021
@hdost
Explicitly Mention Core Components
cf200d6 
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost <harolddost@gmail.com>
@hdost hdost mentioned this issue Dec 18, 2021
Merged
hdost added a commit to hdost/opentelemetry-collector-releases that referenced this issue Dec 18, 2021
@hdost
Explicitly Mention Core Components
f2f04e5 
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost <harolddost@gmail.com>
@jpkrohling
Copy link
Member

We should now have a contrib distribution there so that the path is clear to start doing the same for contrib that was done for core in an earlier PR.

hdost added a commit to hdost/opentelemetry-collector-releases that referenced this issue Dec 20, 2021
@hdost
Explicitly Mention Core Components
b9ca0c9 
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits
* Update .gorelaser.yml because you have to for things to merge :P

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost <harolddost@gmail.com>
jpkrohling pushed a commit to open-telemetry/opentelemetry-collector-releases that referenced this issue Dec 21, 2021
@hdost
Explicitly Mention Core Components (#48)
a83f3b4 
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost <harolddost@gmail.com>
@rltoSD rltoSD mentioned this issue Dec 21, 2021
Merged
@bogdandrutu bogdandrutu mentioned this issue Jan 3, 2022
Merged
@bogdandrutu bogdandrutu removed this from the core-release-v37 milestone Jan 18, 2022
@bryan-aguilar bryan-aguilar mentioned this issue Feb 21, 2022
Merged
@atoulme
Copy link
Contributor

atoulme commented Dec 14, 2023

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alolita alolita

@JamesJHPark JamesJHPark

Labels
area:internal easy Complexity: Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpkrohling @atoulme @bogdandrutu @alolita @JamesJHPark @alexperez52