Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disable/enable from components #347

Closed
bogdandrutu opened this issue Sep 13, 2019 · 3 comments · Fixed by #909
Closed

Remove disable/enable from components #347

bogdandrutu opened this issue Sep 13, 2019 · 3 comments · Fixed by #909
Assignees
@pjanotti
Milestone
Alpha v0.3

Comments

@bogdandrutu
Copy link
Member

Currently we do have two ways to control if a component is disabled/enabled:

  1. Via the disabled property
  2. If the component is present in a pipeline/extension list.

I would suggest that we keep only the second option to control if the component is enabled/disabled.
@bogdandrutu bogdandrutu mentioned this issue Sep 13, 2019
Closed
@tigrannajaryan tigrannajaryan added this to the Beta Release milestone Sep 24, 2019
@tigrannajaryan
Copy link
Member

@pjanotti please comment. We need to settle this before Beta release.

@pjanotti
Copy link
Contributor

pjanotti commented Sep 24, 2019 •
edited
Loading

SGTM. The only possible use for disabled is to keep configuration and quickly disable something but with VCS and a good text editor it is trivial to workaround that.

@pjanotti pjanotti self-assigned this Sep 30, 2019
@pjanotti pjanotti removed this from the Alpha v0.2 milestone Oct 2, 2019
@tigrannajaryan tigrannajaryan added this to the Alpha v0.3 milestone Oct 3, 2019
@bogdandrutu bogdandrutu mentioned this issue May 2, 2020
Merged
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@ferhatelmas @rghetia
Rename GetTracer to Tracer (open-telemetry#347)
0f052af 
* Rename GetTracer to NewTracer

* Drop New prefix
@ringerc
Copy link

ringerc commented May 9, 2022

@pjanotti

SGTM. The only possible use for disabled is to keep configuration and quickly disable something but with VCS and a good text editor it is trivial to workaround that.

It was possible to enable/disable using env-var substitution using this property, but isn't very practical to do so with e.g. the otel operator by adding/removing from the pipelines component list.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
413aa94 
…y#347)

Bumps [boto3](https://github.com/boto/boto3) from 1.17.54 to 1.17.60.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.17.54...1.17.60)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@ThomsonTan
Add explicit type conversion to narrower data type (open-telemetry#347)
cbcc63e
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@TylerHelmuth
[opentelemetry-demo] Refactor default env vars (open-telemetry#347)
4bfcee1 
* refactor default env vars

* bump chart version

* update component interface

* fix component dictionary

* merge in upstream/main

* bump chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjanotti pjanotti

Labels
None yet
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

Remove isEnabled from the config model interface bogdandrutu/opentelemetry-collector
4 participants
@ringerc @bogdandrutu @tigrannajaryan @pjanotti