Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --set flag #1907

Closed
pavolloffay opened this issue Oct 5, 2020 · 0 comments · Fixed by #2162
Closed

Fix --set flag #1907

pavolloffay opened this issue Oct 5, 2020 · 0 comments · Fixed by #2162
Labels
enhancement New feature or request

Comments

@pavolloffay
Copy link
Member

Support for --set flag has been reverted in #1897.

The referenced issue should be fixed and support for --set flag added back.
@joe-elliott joe-elliott mentioned this issue Oct 15, 2020
Closed
@joe-elliott joe-elliott mentioned this issue Nov 16, 2020
Merged
tigrannajaryan pushed a commit that referenced this issue Dec 1, 2020
@joe-elliott
Fix --set flag (#2162)
cb608a9 
Add the --set parameter in a way that works with `{}` being used in configs.

Fixes #1907 

**Testing:**
The original tests were added along with the addition of the following:

```
extensions:
  health_check: {}
```

This failed the previous tests, but now passes.
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Update release doc (open-telemetry#1907)
74ba546
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@sanjaypujare
Update meter.h (open-telemetry#1907)
8a9d085 
Fix typo: replace Counter with Gauge (most likely a copy-paste error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --set flag joe-elliott/opentelemetry-collector
2 participants
@andrewhsu @pavolloffay