-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsNil in pdata causes panic: nil pointer dereference #1731
Labels
bug
Something isn't working
Comments
The method logic should be for instance
|
This is not a valid usage as it is described in the comments for pdata.Resource: // Must use NewResource function to create new instances.
// Important: zero-initialized instance is not valid for use.
type Resource struct { |
How does the consumer of the resource/pdata structs know that the struct is zero initialized? There should be an API to check for that. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this issue
Nov 11, 2021
….Context (open-telemetry#1731) * Store Span instead of local/remote SpanContext in Context Now that the SpanContext has a remote identifier, storing a Span's SpanContext two separate ways in a Context (one for local another for remote) is unnecessary and adds complication throughout the project when determining heredity of a Span. This moves to storing the Span directly in the Context uniformly (for both local and remote) as current Span. In the process, it updates the getter/setter functionality the `trace` package provides and replaces the distributed heredity logic throughout the project with just using the current Span as the parent if it exists. * Update trace/context.go Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Assert propagators context remote state Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this issue
Apr 27, 2023
…y#1731) Bumps [boto3](https://github.com/boto/boto3) from 1.24.17 to 1.24.18. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.17...1.24.18) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this issue
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
IsNil
methods frompdata
package causepanic: nil pointer dereference
.Steps to reproduce
What did you expect to see?
Not panic either
false
ortrue
.What did you see instead?
panic
What version did you use?
What config did you use?
Environment
Additional context
cc @tigrannajaryan
The text was updated successfully, but these errors were encountered: