Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Add ToClientOption #12353

Closed
mx-psi opened this issue Feb 11, 2025 · 0 comments · Fixed by #12354
Closed

[confighttp] Add ToClientOption #12353

mx-psi opened this issue Feb 11, 2025 · 0 comments · Fixed by #12354
Assignees
@mx-psi
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 11, 2025

Component(s)

No response

Describe the issue you're reporting

Add ToClientOption type and pass it to confighttp.ClientConfig.ToClient to future-proof the API.
@mx-psi mx-psi self-assigned this Feb 11, 2025
@mx-psi mx-psi moved this from Todo to Waiting for reviews in Collector: v1 Feb 11, 2025
@mx-psi mx-psi mentioned this issue Feb 11, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2025
@mx-psi
[confighttp] Add ToClientOption (#12354)
d95b2d9 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Adds `ToClientOption` option type to future-proof `ToClient` method. It
has no current uses.

Skipping the deprecation process per [this
exception](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/coding-guidelines.md#exceptions).

#### Link to tracking issue
Fixes #12353
@github-project-automation github-project-automation bot moved this from Waiting for reviews to Done in Collector: v1 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mx-psi mx-psi

Labels
None yet
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/collector/configh...
Development

Successfully merging a pull request may close this issue.

[confighttp] Add ToClientOption mx-psi/opentelemetry-collector
1 participant
@mx-psi