Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull batcher does not correctly count the done/index to signal on terminate #12247

Closed
bogdandrutu opened this issue Feb 2, 2025 · 0 comments · Fixed by #12260
Closed

Pull batcher does not correctly count the done/index to signal on terminate #12247

bogdandrutu opened this issue Feb 2, 2025 · 0 comments · Fixed by #12260
Labels
bug Something isn't working

Comments

@bogdandrutu
Copy link
Member

The bug was before the conversion to done callback, but here I will show the links after done callback change.

  • If an existing batch is current with data, and a new request comes that makes the batch to exceed the minimum limit or getting split the previous done callback is not called.

See

qb.flush(ctx, reqList[i], []exporterqueue.DoneCallback{done})
even if the reqList is created
reqList, mergeSplitErr = qb.currentBatch.req.MergeSplit(ctx, qb.batchCfg.MaxSizeConfig, req)
we don't signal existing "dones".

@bogdandrutu bogdandrutu added the bug Something isn't working label Feb 2, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 2, 2025
…rterQueueBatcher to beta" (#12246)

Reverts #12122

During the revamp of the pull batching work, couple bugs were found:
1.
#12244
2.
#12247
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
…#12260)

Fixes
#12247

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant