[otlp] add optional min/max fields to histograms (#5399)

* [otlp] add optional min/max fields to histograms Fixes #5380 * update changelog * don't bother defining reusable variables
open-telemetry · May 19, 2022 · c56d20e · c56d20e
1 parent 95c5f4d
commit c56d20e
Show file tree

Hide file tree

Showing 4 changed files with 153 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@
 ### 💡 Enhancements 💡
 
 - Update OTLP to v0.17.0 (#5335)
+  - Add optional min/max fields to histograms (#5399)
 
 ### 🧰 Bug fixes 🧰
 

diff --git a/pdata/internal/cmd/pdatagen/internal/metrics_structs.go b/pdata/internal/cmd/pdatagen/internal/metrics_structs.go
@@ -289,6 +289,24 @@ var histogramDataPoint = &messageValueStruct{
 		explicitBoundsField,
 		exemplarsField,
 		dataPointFlagsField,
+		&optionalPrimitiveValue{
+			fieldName:        "Min",
+			fieldType:        "Double",
+			originFieldName:  "Min",
+			originTypePrefix: "otlpmetrics.HistogramDataPoint_",
+			returnType:       "float64",
+			defaultVal:       "float64(0.0)",
+			testVal:          "float64(9.23)",
+		},
+		&optionalPrimitiveValue{
+			fieldName:        "Max",
+			fieldType:        "Double",
+			originFieldName:  "Max",
+			originTypePrefix: "otlpmetrics.HistogramDataPoint_",
+			returnType:       "float64",
+			defaultVal:       "float64(0.0)",
+			testVal:          "float64(182.55)",
+		},
 	},
 }
 
@@ -338,6 +356,24 @@ var exponentialHistogramDataPoint = &messageValueStruct{
 		},
 		exemplarsField,
 		dataPointFlagsField,
+		&optionalPrimitiveValue{
+			fieldName:        "Min",
+			fieldType:        "Double",
+			originFieldName:  "Min",
+			originTypePrefix: "otlpmetrics.ExponentialHistogramDataPoint_",
+			returnType:       "float64",
+			defaultVal:       "float64(0.0)",
+			testVal:          "float64(9.23)",
+		},
+		&optionalPrimitiveValue{
+			fieldName:        "Max",
+			fieldType:        "Double",
+			originFieldName:  "Max",
+			originTypePrefix: "otlpmetrics.ExponentialHistogramDataPoint_",
+			returnType:       "float64",
+			defaultVal:       "float64(0.0)",
+			testVal:          "float64(182.55)",
+		},
 	},
 }
 

diff --git a/pdata/internal/generated_pmetric.go b/pdata/internal/generated_pmetric.go
diff --git a/pdata/internal/generated_pmetric_test.go b/pdata/internal/generated_pmetric_test.go