Add Validate method to QueueSettings struct

open-telemetry · Feb 3, 2022 · 1bf5ff4 · 1bf5ff4
1 parent 32301d9
commit 1bf5ff4
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/exporter/exporterhelper/queued_retry_experimental.go b/exporter/exporterhelper/queued_retry_experimental.go
@@ -62,6 +62,19 @@ func DefaultQueueSettings() QueueSettings {
 	}
 }
 
+// Validate checks if the QueueSettings configuration is valid
+func (qCfg *QueueSettings) Validate() error {
+	if qCfg.QueueSize < 0 {
+		return fmt.Errorf("queue size can't be negative")
+	}
+
+	if qCfg.Enabled && qCfg.QueueSize == 0 {
+		return fmt.Errorf("a 0 size queue will drop all the data")
+	}
+
+	return nil
+}
+
 var (
 	errNoStorageClient        = errors.New("no storage client extension found")
 	errMultipleStorageClients = errors.New("multiple storage extensions found")

diff --git a/exporter/exporterhelper/queued_retry_inmemory.go b/exporter/exporterhelper/queued_retry_inmemory.go
@@ -57,6 +57,19 @@ func DefaultQueueSettings() QueueSettings {
 	}
 }
 
+// Validate checks if the QueueSettings configuration is valid
+func (qCfg *QueueSettings) Validate() error {
+	if qCfg.QueueSize < 0 {
+		return fmt.Errorf("queue size can't be negative")
+	}
+
+	if qCfg.Enabled && qCfg.QueueSize == 0 {
+		return fmt.Errorf("a 0 size queue will drop all the data")
+	}
+
+	return nil
+}
+
 type queuedRetrySender struct {
 	fullName        string
 	cfg             QueueSettings