Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Exclude 386 from opentelemetry-collector-contrib builds" #144

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Revert "Exclude 386 from opentelemetry-collector-contrib builds" #144

merged 1 commit into from
Jun 3, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 1, 2022 •
edited
Loading

Reverts #83

@mx-psi
Copy link
Member Author

mx-psi commented Jun 1, 2022

cc @codeboten, I think we can add 386 builds now after your last PR on contrib?

@mx-psi mx-psi marked this pull request as ready for review June 1, 2022 16:20
@mx-psi mx-psi requested review from a team and dmitryax June 1, 2022 16:20
codeboten
codeboten approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@mx-psi mx-psi linked an issue Jun 3, 2022 that may be closed by this pull request
distribution for arm7 #105
Open
@mx-psi mx-psi mentioned this pull request Jun 3, 2022
Open
@mx-psi mx-psi removed a link to an issue Jun 3, 2022
distribution for arm7 #105
Open
@codeboten codeboten merged commit 8032c7b into main Jun 3, 2022
@codeboten codeboten deleted the revert-83-mx-psi/exclude-i386 branch June 3, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mx-psi @codeboten