Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/mezmoexporter] Add the Mezmo Log exporter #9743

Merged
merged 40 commits into from
May 17, 2022

Conversation

billmeyer
Copy link
Member

Description:

This adds a new exporter capable of exporting logs to the LogDNA/Mezmo platform as outlined in 9599.

Only the log telemetry type is supported at this time.

Link to tracking Issue: 9599

Testing:

Unit test cases have been developed to test the bulk of the available interactions. Testing coverage is presently at 93.4%:

opentelemetry-collector-contrib/exporter/mezmoexporter$ go test ./... -cover
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/mezmoexporter	0.567s	coverage: 93.4% of statements

Documentation:

README.md file is available with sample configuration entries needed to use the exporter with LogDNA.

@billmeyer billmeyer requested review from a team and codeboten May 4, 2022 21:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CODEOWNERS with myself, and the two logdna owners as we discussed.

exporter/mezmoexporter/README.md Outdated Show resolved Hide resolved
exporter/mezmoexporter/README.md Outdated Show resolved Hide resolved
exporter/mezmoexporter/README.md Outdated Show resolved Hide resolved
exporter/mezmoexporter/config.go Show resolved Hide resolved
exporter/mezmoexporter/config.go Outdated Show resolved Hide resolved
exporter/mezmoexporter/exporter.go Outdated Show resolved Hide resolved
exporter/mezmoexporter/exporter.go Outdated Show resolved Hide resolved
exporter/mezmoexporter/exporter.go Show resolved Hide resolved
exporter/mezmoexporter/exporter.go Show resolved Hide resolved
exporter/mezmoexporter/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, please resolve the conflicts

exporter/mezmoexporter/README.md Outdated Show resolved Hide resolved
exporter/mezmoexporter/README.md Outdated Show resolved Hide resolved
exporter/mezmoexporter/doc.go Outdated Show resolved Hide resolved
@billmeyer billmeyer requested a review from codeboten May 10, 2022 23:10
.github/CODEOWNERS Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label May 16, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 00e32e8 into open-telemetry:main May 17, 2022
jamesmoessis pushed a commit to jamesmoessis/opentelemetry-collector-contrib that referenced this pull request May 20, 2022
)

* Added implementation of Mezmo Log exporter.

* Additional files to prepare for PR to contrib

* Initial revision

* Changes to support batching of log uploads to not exceed maximum allowed POST size

* Update exporter/mezmoexporter/exporter.go

Slimmed code down to be more compact.

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Added the appropriate code owners the the Mezmo Exporter

* Moved test functions to test file

* Cleaned up README and standardized URLs across examples

* Cleanup to remove commented code and non-exported functions

* Fixed a typo

* Added TODO entry for removing hostname from the HTTP POST when it's no longer required by the backend

* Removed year from the Copyright header

* Fixed a typo in the mezmo exporter definition

* Made the ingest_url an optional configuration with a known default value.

* Changes to enable a default ingest URL as well as allow an override from the config.

* Updates from rm -fr go.sum
go mod tidy -compat=1.17

* Added new Mezmo Exporter component

* Added return value checks for some tests

* Removed some unneeded code from the last merge

* Reverted the release version to unreleased

* Proper version for the new component

* Applied make goporto updates

* Fixed a unit test case for the default config test

* Bumped the version number for the go.opentelemetry.io/collector versions

* Module updates for latest release

* Removed the newrelicexporter as it has been removed

* Updates from the latest make gotidy for the merge to main

* Pulled semconv from go.opentelemetry.io/collector/semconv instead of go.opentelemetry.io/collector/semconv/model

* Moved the mezmo new component under Unreleased and fixed the associated PR number

Co-authored-by: David Ashpole <dashpole@google.com>
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
)

* Added implementation of Mezmo Log exporter.

* Additional files to prepare for PR to contrib

* Initial revision

* Changes to support batching of log uploads to not exceed maximum allowed POST size

* Update exporter/mezmoexporter/exporter.go

Slimmed code down to be more compact.

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Update exporter/mezmoexporter/exporter.go

Co-authored-by: David Ashpole <dashpole@google.com>

* Added the appropriate code owners the the Mezmo Exporter

* Moved test functions to test file

* Cleaned up README and standardized URLs across examples

* Cleanup to remove commented code and non-exported functions

* Fixed a typo

* Added TODO entry for removing hostname from the HTTP POST when it's no longer required by the backend

* Removed year from the Copyright header

* Fixed a typo in the mezmo exporter definition

* Made the ingest_url an optional configuration with a known default value.

* Changes to enable a default ingest URL as well as allow an override from the config.

* Updates from rm -fr go.sum
go mod tidy -compat=1.17

* Added new Mezmo Exporter component

* Added return value checks for some tests

* Removed some unneeded code from the last merge

* Reverted the release version to unreleased

* Proper version for the new component

* Applied make goporto updates

* Fixed a unit test case for the default config test

* Bumped the version number for the go.opentelemetry.io/collector versions

* Module updates for latest release

* Removed the newrelicexporter as it has been removed

* Updates from the latest make gotidy for the merge to main

* Pulled semconv from go.opentelemetry.io/collector/semconv instead of go.opentelemetry.io/collector/semconv/model

* Moved the mezmo new component under Unreleased and fixed the associated PR number

Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants