-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/mezmoexporter] Add the Mezmo Log exporter #9743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry to CODEOWNERS with myself, and the two logdna owners as we discussed.
Slimmed code down to be more compact. Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: David Ashpole <dashpole@google.com>
dashpole
reviewed
May 6, 2022
…o longer required by the backend
codeboten
reviewed
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions, please resolve the conflicts
go mod tidy -compat=1.17
dashpole
reviewed
May 11, 2022
dashpole
reviewed
May 11, 2022
dashpole
reviewed
May 11, 2022
dashpole
reviewed
May 12, 2022
dashpole
approved these changes
May 12, 2022
dashpole
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
May 16, 2022
bogdandrutu
reviewed
May 16, 2022
…go.opentelemetry.io/collector/semconv/model
codeboten
reviewed
May 17, 2022
jamesmoessis
pushed a commit
to jamesmoessis/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2022
) * Added implementation of Mezmo Log exporter. * Additional files to prepare for PR to contrib * Initial revision * Changes to support batching of log uploads to not exceed maximum allowed POST size * Update exporter/mezmoexporter/exporter.go Slimmed code down to be more compact. Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Added the appropriate code owners the the Mezmo Exporter * Moved test functions to test file * Cleaned up README and standardized URLs across examples * Cleanup to remove commented code and non-exported functions * Fixed a typo * Added TODO entry for removing hostname from the HTTP POST when it's no longer required by the backend * Removed year from the Copyright header * Fixed a typo in the mezmo exporter definition * Made the ingest_url an optional configuration with a known default value. * Changes to enable a default ingest URL as well as allow an override from the config. * Updates from rm -fr go.sum go mod tidy -compat=1.17 * Added new Mezmo Exporter component * Added return value checks for some tests * Removed some unneeded code from the last merge * Reverted the release version to unreleased * Proper version for the new component * Applied make goporto updates * Fixed a unit test case for the default config test * Bumped the version number for the go.opentelemetry.io/collector versions * Module updates for latest release * Removed the newrelicexporter as it has been removed * Updates from the latest make gotidy for the merge to main * Pulled semconv from go.opentelemetry.io/collector/semconv instead of go.opentelemetry.io/collector/semconv/model * Moved the mezmo new component under Unreleased and fixed the associated PR number Co-authored-by: David Ashpole <dashpole@google.com>
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
) * Added implementation of Mezmo Log exporter. * Additional files to prepare for PR to contrib * Initial revision * Changes to support batching of log uploads to not exceed maximum allowed POST size * Update exporter/mezmoexporter/exporter.go Slimmed code down to be more compact. Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Update exporter/mezmoexporter/exporter.go Co-authored-by: David Ashpole <dashpole@google.com> * Added the appropriate code owners the the Mezmo Exporter * Moved test functions to test file * Cleaned up README and standardized URLs across examples * Cleanup to remove commented code and non-exported functions * Fixed a typo * Added TODO entry for removing hostname from the HTTP POST when it's no longer required by the backend * Removed year from the Copyright header * Fixed a typo in the mezmo exporter definition * Made the ingest_url an optional configuration with a known default value. * Changes to enable a default ingest URL as well as allow an override from the config. * Updates from rm -fr go.sum go mod tidy -compat=1.17 * Added new Mezmo Exporter component * Added return value checks for some tests * Removed some unneeded code from the last merge * Reverted the release version to unreleased * Proper version for the new component * Applied make goporto updates * Fixed a unit test case for the default config test * Bumped the version number for the go.opentelemetry.io/collector versions * Module updates for latest release * Removed the newrelicexporter as it has been removed * Updates from the latest make gotidy for the merge to main * Pulled semconv from go.opentelemetry.io/collector/semconv instead of go.opentelemetry.io/collector/semconv/model * Moved the mezmo new component under Unreleased and fixed the associated PR number Co-authored-by: David Ashpole <dashpole@google.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a new exporter capable of exporting logs to the LogDNA/Mezmo platform as outlined in 9599.
Only the
log
telemetry type is supported at this time.Link to tracking Issue: 9599
Testing:
Unit test cases have been developed to test the bulk of the available interactions. Testing coverage is presently at 93.4%:
Documentation:
README.md
file is available with sample configuration entries needed to use the exporter with LogDNA.