Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core dependency and adopt code to the API changes #8791

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Update core dependency and adopt code to the API changes #8791

merged 1 commit into from
Mar 23, 2022

Conversation

dmitryax
Copy link
Member

Remove usage of deprecated API:

  • pdata.AttributeMap
  • pdata.NewAttributeMap
  • pdata.NewAttributeMapFromMap
  • pdata.AttributeValueSlice
  • pdata.NewAttributeValueSlice

Remove usage of deleted pdata.InternalRep

@dmitryax dmitryax requested a review from a team March 23, 2022 00:18
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 23, 2022
@dmitryax dmitryax force-pushed the upgrade-core branch 2 times, most recently from 66a6463 to 92ce215 Compare March 23, 2022 01:40
codeboten
codeboten reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase now that #8807 is merged

@dmitryax dmitryax force-pushed the upgrade-core branch 2 times, most recently from 726e69a to 76c15ea Compare March 23, 2022 05:16
@dmitryax
Copy link
Member Author

@codeboten done

codeboten
codeboten reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! as i was reviewing another pr got merged and there's a new conflict to resolve

@dmitryax dmitryax force-pushed the upgrade-core branch 3 times, most recently from 8f22ec4 to 89c2f4c Compare March 23, 2022 19:28
@dmitryax
Update core dependency and adopt to API changes
87d6a9d 
Remove usage of deprecated API:
- `pdata.AttributeMap`
- `pdata.NewAttributeMap`
- `pdata.NewAttributeMapFromMap`
- `pdata.AttributeValueSlice`
- `pdata.NewAttributeValueSlice`

Remove usage of deleted `pdata.InternalRep`
@dmitryax
Copy link
Member Author

dmitryax commented Mar 23, 2022 •
edited
Loading

@codeboten no problem. I rebased and got the tests passing. PTAL

@codeboten codeboten merged commit ac8d866 into open-telemetry:main Mar 23, 2022
@dmitryax dmitryax deleted the upgrade-core branch March 24, 2022 00:49
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@anuraaga anuraaga Awaiting requested review from anuraaga

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@punya punya Awaiting requested review from punya

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@alolita alolita Awaiting requested review from alolita

Assignees

@djaglowski djaglowski

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitryax @codeboten @djaglowski