[processor/transform] Extract function arguments into separate object… #8339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for easier extension
Description: Extracts arguments passed to transform functions into a struct for easy extension
@Aneurysm9 had originally had this idea and initially I went with simpler listing out the arguments to avoid any performance issues. Because we call functions through function pointers, Go can't really optimize the struct away. That being said, being able to extend the data that is available to a transform function also seems important, for example I heard about a case to provide auth credentials information to transformation. So I want to see what people think of this style.
The benchmarks are consistently slower but for 100 spans ranges from 2-15us or so, getting consistent numbers at this scale is difficult so it seems to still be within noise to some extent. Let me know thoughts.
Link to tracking Issue: #7300
Testing: Unit tests
Documentation:
After
Before