[receiver/cloudfoundry] Enable component #7060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rmfitzpatrick
approved these changes
Jan 10, 2022
The PCF receiver has already been implemented and merged into the contrib repository, however, testing was incomplete and the receiver wasn't enabled by adding its factory to the valid receiver components list. This change adds the required unit testing and enables the receiver.
= Change require.Error to require.EqualError to specify expected error. - Resolve merge conflicts in dependency files.
50d1e0a to
fa6a2e8
Compare
mstumpfx
approved these changes
Jan 11, 2022
jpkrohling
reviewed
Jan 11, 2022
|
Please, also add an entry to the changelog and address the linting failure |
- Add tests to receiver test list - Fix linting failures - Add changes to changelog
|
@bogdandrutu If you could review and merge when you get the chance, it would be much appreciated! |
jpkrohling
approved these changes
Jan 11, 2022
Unit tests are failing on github due to UAA auth errors. These tests require a valid end point for authentication, but the github environment does not meet this bar. These tests should be skipped for now.
auto-merge was automatically disabled
January 11, 2022 19:54
Head branch was pushed to by a user without write access
jpkrohling
approved these changes
Jan 11, 2022
- Linting error hit due to incorrect whitespace in test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Cloud Foundry receiver has already been implemented and merged into the contrib repository, however, testing was incomplete and the receiver wasn't enabled. This change adds the required unit testing and enables the receiver.
Link to tracking Issue:
#5320
Testing:
This change is tests, and additional testing was done by running a Tanzu application service.
Documentation:
No documentation was added as this is a testing change.