Enable native authentication in MySQL #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
reviewed
Dec 8, 2021
receiver/mysqlreceiver/client.go
Outdated
| Net: conf.Transport, | ||
| Addr: conf.Endpoint, | ||
| DBName: conf.Database, | ||
| AllowNativePasswords: true, |
There was a problem hiding this comment.
It seems wrong to just add this without giving users the chance to customize it. Besides, the default value for this seems to indeed be true: what would this change bring?
There was a problem hiding this comment.
It seems that the default was incorrect in testing as it was building the DSN by setting this parameter to false. I'll add it as a config option but default to true.
jpkrohling
approved these changes
Dec 8, 2021
djaglowski
requested changes
Dec 8, 2021
receiver/mysqlreceiver/README.md
Outdated
| @@ -19,6 +19,7 @@ The following settings are optional: | |||
| - `endpoint`: (default = `localhost:3306`) | |||
| - `username`: (default = `root`) | |||
| - `password`: The password to the username. | |||
| - `AllowNativePasswords`: (default = `true`) | |||
There was a problem hiding this comment.
Suggested change
| - `AllowNativePasswords`: (default = `true`) | |
| - `allow_native_passwords`: (default = `true`) |
receiver/mysqlreceiver/config.go
Outdated
| @@ -24,5 +24,6 @@ type Config struct { | |||
| Username string `mapstructure:"username,omitempty"` | |||
| Password string `mapstructure:"password,omitempty"` | |||
| Database string `mapstructure:"database,omitempty"` | |||
| AllowNativePasswords bool `mapstructure:"database,omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| AllowNativePasswords bool `mapstructure:"database,omitempty"` | |
| AllowNativePasswords bool `mapstructure:"allow_native_passwords,omitempty"` |
djaglowski
approved these changes
Dec 8, 2021
jpkrohling
approved these changes
Dec 8, 2021
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Bit of cleanup left over from #6322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for native authentication in mysql.