Ensure hostmetricsreceiver sets SchemaURL #6482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes ensures that all metrics produced by hostmetricsreceiver set the SchemaURL. If no specific SchemaURL is set we assume all collected host metrics confirm to our default SchemaURL. The assumption is that the code that produces these metrics uses semantic conventions defined in package "conventions".
|
@codeboten @bogdandrutu you reviewed the original PR, please review this remake of it. |
codeboten
approved these changes
Dec 2, 2021
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
This changes ensures that all metrics produced by hostmetricsreceiver set the SchemaURL. If no specific SchemaURL is set we assume all collected host metrics confirm to our default SchemaURL. The assumption is that the code that produces these metrics uses semantic conventions defined in package "conventions".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ensures that all metrics produced by hostmetricsreceiver
set the SchemaURL.
If no specific SchemaURL is set we assume all collected host metrics
confirm to our default SchemaURL. The assumption is that the code that
produces these metrics uses semantic conventions defined in
package "conventions".
This is a remake of closed PR open-telemetry/opentelemetry-collector#3819