Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadogexporter] Retry per network call #6412

Merged
Prev Previous commit
Next Next commit
Merge branch 'main' into mx-psi/retries-per-network-call
  • Loading branch information
mx-psi committed Dec 1, 2021
commit 7f7b2e2c40ba2a32071712657ea05baf5f5c1a73
6 changes: 4 additions & 2 deletions exporter/datadogexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ func createMetricsExporter(
cfg,
set,
pushMetricsFn,
exporterhelper.WithTimeout(cfg.TimeoutSettings),
// explicitly disable since we rely on http.Client timeout logic.
exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0 * time.Second}),
// We use our own custom mechanism for retries, since we hit several endpoints.
exporterhelper.WithRetry(exporterhelper.RetrySettings{Enabled: false}),
exporterhelper.WithQueue(cfg.QueueSettings),
Expand Down Expand Up @@ -208,7 +209,8 @@ func createTracesExporter(
cfg,
set,
pushTracesFn,
exporterhelper.WithTimeout(cfg.TimeoutSettings),
// explicitly disable since we rely on http.Client timeout logic.
exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0 * time.Second}),
// We don't do retries on traces because of deduping concerns on APM Events.
exporterhelper.WithRetry(exporterhelper.RetrySettings{Enabled: false}),
exporterhelper.WithQueue(cfg.QueueSettings),
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.