Added metrics cardinality handling for Google Cloud Spanner receiver - part 2. #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpkrohling , this is part 2 of cardinality handling. |
d1d508d to
b456b65
Compare
kostia-hospodarysko
approved these changes
Nov 5, 2021
|
@MovieStoreGuy, would you like to review this one as well? |
b456b65 to
42dffdd
Compare
|
Yeah, let me have a look over this weekend :) Should be done by end of the weekend (depending on your timezones) |
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/filterbymetricbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/itemfilterfactory.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/itemfilterfactory_test.go
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/filterfactory/testhelpers_test.go
Outdated
Show resolved
Hide resolved
42dffdd to
f25a209
Compare
|
@MovieStoreGuy , I replied on all of your comments. Some of them left unresolved (I provided my opinion there), so please, take a look on them. Review was re-requested. |
a87fcbc to
f784026
Compare
asukhyy
approved these changes
Nov 8, 2021
|
@MovieStoreGuy , looks like I addressed all your comments. |
MovieStoreGuy
approved these changes
Nov 8, 2021
|
@jpkrohling , all approvals received. |
3ad53b2 to
d2e41e9
Compare
|
Added to my queue. I'll take a look soon. |
d2e41e9 to
fae0472
Compare
jpkrohling
approved these changes
Nov 10, 2021
receiver/googlecloudspannerreceiver/internal/filterfactory/itemfilterfactory.go
Outdated
Show resolved
Hide resolved
…- part 2. This part contains item filter factory which is responsible for calculation of cardinality limits for metrics and construction of item filters for each metric.
fae0472 to
0c7b16e
Compare
bogdandrutu
approved these changes
Nov 10, 2021
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
…#6148) Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metrics cardinality handling for Google Cloud Spanner receiver - part 2.
This part contains item filter factory which is responsible for calculation of cardinality limits for metrics and construction of item filters for each metric.