Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql add support for different protocols #6138

Merged
merged 8 commits into from
Nov 11, 2021

Conversation

Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Nov 4, 2021

Description:

Add ability to specify protocol in config.

Documentation:
Added transport to optional parameters

@Mrod1598 Mrod1598 marked this pull request as ready for review November 4, 2021 20:46
@Mrod1598 Mrod1598 requested a review from djaglowski as a code owner November 4, 2021 20:46
@Mrod1598 Mrod1598 requested a review from a team November 4, 2021 20:46
@djaglowski djaglowski assigned djaglowski and unassigned kbrockhoff Nov 8, 2021
receiver/mysqlreceiver/scraper.go Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
@Mrod1598 Mrod1598 requested a review from djaglowski November 9, 2021 19:57
@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Nov 10, 2021
@djaglowski djaglowski requested a review from codeboten November 11, 2021 14:18
Comment on lines 65 to 67
m.stopOnce.Do(func() {
err = m.client.Close()
err = m.sqlclient.Close()
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djaglowski this seems wrong:

  1. It is guarantee that shutdown is called only once (so no need to protect with once).
  2. If start fails sqlclient is nil and this will crash here.

Probably fix this in a separate PR.

@bogdandrutu bogdandrutu merged commit 650ee77 into open-telemetry:main Nov 11, 2021
@Mrod1598 Mrod1598 deleted the mysql-add-unix-support branch March 9, 2022 20:52
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
* Changed how the telemetryInitializer is created to make it so it's not global

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

* Updated changelog

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

* Fixed linter error

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

* Moved register of Internal Metrics Featuregate to an init function and removed once logic

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants