-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mysql add support for different protocols #6138
Merged
bogdandrutu
merged 8 commits into
open-telemetry:main
from
observIQ:mysql-add-unix-support
Nov 11, 2021
Merged
Mysql add support for different protocols #6138
bogdandrutu
merged 8 commits into
open-telemetry:main
from
observIQ:mysql-add-unix-support
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Nov 9, 2021
djaglowski
reviewed
Nov 10, 2021
djaglowski
approved these changes
Nov 10, 2021
djaglowski
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 10, 2021
bogdandrutu
reviewed
Nov 11, 2021
Comment on lines
65
to
67
m.stopOnce.Do(func() { | ||
err = m.client.Close() | ||
err = m.sqlclient.Close() | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djaglowski this seems wrong:
- It is guarantee that shutdown is called only once (so no need to protect with once).
- If start fails sqlclient is nil and this will crash here.
Probably fix this in a separate PR.
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
* Changed how the telemetryInitializer is created to make it so it's not global Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Updated changelog Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Fixed linter error Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Moved register of Internal Metrics Featuregate to an init function and removed once logic Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add ability to specify protocol in config.
Documentation:
Added transport to optional parameters