[Minor] Refactor the client Authenticators for the new "ClientAuthenticator" interfaces #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enticator" interfaces
|
@jpkrohling please review this. Thank you. |
anuraaga
reviewed
Oct 26, 2021
| var _ configauth.GRPCClientAuthenticator = (*BearerTokenAuth)(nil) | ||
| var ( | ||
| _ configauth.ClientAuthenticator = (*BearerTokenAuth)(nil) | ||
| errNotHTTPClientAuthenticator = errors.New("requested authenticator is not a HTTP client authenticator") |
There was a problem hiding this comment.
Isn't this extension usable, or otherwise should be usable, with gRPC or HTTP? A bearer token is a common concept of HTTP. What is the future direction for the extension?
There was a problem hiding this comment.
It should be usable with both
There was a problem hiding this comment.
Also, the formatting of these two lines is a bit odd. I think it would be better to have two lines starting with var instead of grouping them together.
bogdandrutu
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As a part of Removing protocol specific client authentication interfaces (open-telemetry/opentelemetry-collector#4239) client authenticators will have to implement top level "ClientAuthenticator" which now comprises of all the protocol interfaces.
This PR does some minor adjustments to implementations and removes explicit references to old protocol specific interface types and implements NoOps for missing methods
Link to tracking Issue: #5904
Testing
Note that this PR can be merged regardless of the core PR because of Go's implicit way of treating interfaces.