k8sobserver: only record pod endpoints for running pods #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the k8sobserver to only add a pod level endpoint if the Pod is currently running. This prevents a situation in which receivers consuming from the k8sobserver would continue to interact with a Pod endpoint after the Pod had completed. In the worst case this would result in misleading results as other running pods could re-use the Pod's IP address and telemetry data would be misattributed.
anuraaga
approved these changes
Oct 25, 2021
|
@anuraaga Seems to have failed on a load test, but its not clear to me how this change would impact that. Any ideas? |
|
Hey folks, any thoughts on this one? Would love to be able to rely on the k8sobserver for this use case. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Commenting to prevent this issue from being closed. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This is still an issue. Would love to reach a resolution here so we can leverage the K8s Observer for metrics. |
|
@bogdandrutu @anuraaga Just a friendly ping. Are there any outstanding questions here? Is there anything I can do on my end to push this forward? |
|
@jpkrohling Would you be able to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change updates the k8sobserver to only add a pod level endpoint if the Pod is currently running.
This prevents a situation in which receivers consuming from the k8sobserver would continue to interact with a Pod endpoint after the Pod had completed. In the worst case this would result in misleading results as other running pods could re-use the Pod's IP address and telemetry data would be misattributed.
Specifically, we observed this issue when using the
receivercreatorto scrape prometheus endpoints from pods associated with long running jobs.Note: Should this be a configuration option? Are there ever situation in which a resource would like to track endpoints for non running pods?
Link to tracking Issue:
Testing:
Unit tests.
Documentation:
Unclear if this is necessary. But will add if needed.