[datadogexporter] Remove obsolete report_buckets config #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Oct 21, 2021
bogdandrutu
reviewed
Oct 21, 2021
Comment on lines
+325
to
+327
| // metrics::report_buckets is obsolete, return an error to | ||
| // tell the user to use metrics::histograms::mode instead. | ||
| if configMap.IsSet("metrics::report_buckets") { |
There was a problem hiding this comment.
Not sure if this is necessary, an error will be thrown anyway because the field will not be recognized. Up to you.
There was a problem hiding this comment.
Yes, I decided to leave it in order to print the more specific error 'metrics::report_buckets' is obsolete. Use 'metrics::histograms::mode' instead so that users know what to do to fix it. We can probably remove it after a few releases.
There was a problem hiding this comment.
Sounds good, maybe add a tracking issue and assign to you or @mx-psi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes the
metrics::report_bucketsoption (themetrics::histograms::modeoption should be used instead), which has been deprecated for two releases (v0.36.0andv0.37.0).Link to tracking Issue: n/a
Testing: Modified unit tests to fit the new situation.
Documentation: Modified inline docs & config examples.