Log and report missing metric values. #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0645711 to
ad86e40
Compare
oppegard
suggested changes
Oct 25, 2021
thepeterstone
approved these changes
Nov 4, 2021
bogdandrutu
reviewed
Nov 5, 2021
Aneurysm9
approved these changes
Nov 11, 2021
d8d5479 to
21ed322
Compare
|
Rebased to latest version of main branch to see if that would kick off the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a metric with a missing value comes in to be exported, log that it happened. Also report the number of times metrics with missing values happen to wavefront.
Testing:
Unit tests only.