Adding configurable dockerAPIVersion option for Docker stats receiver #5179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
approved these changes
Sep 9, 2021
tigrannajaryan
approved these changes
Sep 10, 2021
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…-telemetry#5179) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the dockerAPIVersion field in the Docker stats receiver is hard coded to a particular version (v1.22).
It's good to be able to modify that value via the config, the default will still be v1.22 and the config validator ensures that users do not use any value <v.1.22, if they use an invalid api version the collector will fail to start with the proper error message.