Move healthcheckextension from collector core to collector contrib #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
reviewed
Aug 26, 2021
| "go.opentelemetry.io/collector/extension/pprofextension" | ||
| "go.opentelemetry.io/collector/extension/zpagesextension" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckextension" | ||
|
|
There was a problem hiding this comment.
Suggested change
Be sure to run goimports on this. These probably need to be resorted alphabetically.
|
Also needs a rebase |
319db51 to
9c97ea9
Compare
|
Needs a rebase and fix tests :) |
9c97ea9 to
76295d6
Compare
bogdandrutu
approved these changes
Aug 27, 2021
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…etry#4894) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.44.0 to 1.44.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.44.0...v1.44.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jsalva
added a commit
to jsalva/nestjs-otel-prom-grafana-tempo-otel-collector
that referenced
this pull request
Sep 7, 2022
…moved to contrib (see open-telemetry/opentelemetry-collector-contrib#4894). Also updates otel-collector-config using updated format to ignore insecure tls properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves healthcheckextension to collector contrib and updates imports and go mod of several components to point to extension/healthcheckextension
Related issues include:
opentelemetry-collector/#3474