Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS CloudWatch sequence token handling for new/empty log streams #4717

Conversation

errordeveloper
Copy link
Contributor

Description: Handle nil sequence token for empty log streams
Link to tracking Issue: #4683

@errordeveloper errordeveloper requested review from a team and owais August 18, 2021 15:45
@errordeveloper
Copy link
Contributor Author

/cc @mxiamxia @Aneurysm9

@@ -73,6 +73,10 @@ func (e *exporter) Start(ctx context.Context, host component.Host) error {
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of CW Logs use case, the log group/stream needs to be created in flight for the first time use. I think we should create Stream based on Config instead of failing the exporter.

@mxiamxia
Copy link
Member

CWLogs exporter is in pretty early stage. There are a few MUST to be done things,

  1. Batch log events and make sure the batch size is less then 1MB when calls PutLogsEvent API
  2. each single logs event size should be less than 256KB
  3. Create Log Group/Stream in flight from Config if it is not yet found in CW logs backend.
  4. Gracefully handle CW Logs API exceptions in response
  5. ...

@mxiamxia
Copy link
Member

Created an issue to track TODO for CWLogs Exporter. I am fine to merge this PR.

@bogdandrutu bogdandrutu merged commit 35717d4 into open-telemetry:main Aug 18, 2021
@errordeveloper errordeveloper deleted the fix-awscloudwatchlogs-init-sequence-token branch August 20, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants