Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate oidcauthextension from Collector core to Collector contrib #4659

Merged

Conversation

Saber-W
Copy link
Member

@Saber-W Saber-W commented Aug 16, 2021

Description:
This PR migrates the oidcauthextension component from the Collector core repository to the Collector contrib repository.

This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.

Link to tracking Issue:
opentelemetry-collector/#3474
opentelemetry-collector/#3652

@Saber-W Saber-W requested review from a team and owais August 16, 2021 19:28
@alolita alolita added release:required-for-ga Must be resolved before GA release spec:trace labels Aug 16, 2021
@alolita
Copy link
Member

alolita commented Aug 16, 2021

Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks!

@Saber-W Saber-W force-pushed the oidcauthextension-migration branch 2 times, most recently from 0640d20 to 173b6f0 Compare August 20, 2021 16:39
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should show the files moved not new files

@Saber-W Saber-W force-pushed the oidcauthextension-migration branch from 173b6f0 to 4193214 Compare August 20, 2021 16:41
@Saber-W Saber-W requested a review from bogdandrutu August 20, 2021 16:42
@Saber-W Saber-W force-pushed the oidcauthextension-migration branch from 4193214 to 49e1197 Compare August 20, 2021 16:58
@Saber-W Saber-W force-pushed the oidcauthextension-migration branch from 49e1197 to 3995d39 Compare August 20, 2021 17:02
require (
github.com/coreos/go-oidc v2.2.1+incompatible
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.33.1-0.20210820002854-d3000232f8f6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a go.opentelemetry.io/collector/model v0.33.1-0.20210820002854-d3000232f8f6 // indirect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	go.opentelemetry.io/collector/model v0.33.1-0.20210820002854-d3000232f8f6 // indirect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then run go mod tidy in this dir

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay - will do

@Saber-W Saber-W force-pushed the oidcauthextension-migration branch from 3995d39 to 55086dc Compare August 20, 2021 17:41
@bogdandrutu bogdandrutu merged commit 1aea659 into open-telemetry:main Aug 20, 2021
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
Fix bunch of places in tests where we had duplicate code to avoid circular dependencies.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga Must be resolved before GA release spec:trace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants