-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate oidcauthextension from Collector core to Collector contrib #4659
Migrate oidcauthextension from Collector core to Collector contrib #4659
Conversation
Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks! |
0640d20
to
173b6f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR should show the files moved not new files
173b6f0
to
4193214
Compare
4193214
to
49e1197
Compare
49e1197
to
3995d39
Compare
require ( | ||
github.com/coreos/go-oidc v2.2.1+incompatible | ||
github.com/stretchr/testify v1.7.0 | ||
go.opentelemetry.io/collector v0.33.1-0.20210820002854-d3000232f8f6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a go.opentelemetry.io/collector/model v0.33.1-0.20210820002854-d3000232f8f6 // indirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.opentelemetry.io/collector/model v0.33.1-0.20210820002854-d3000232f8f6 // indirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then run go mod tidy
in this dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay - will do
3995d39
to
55086dc
Compare
Fix bunch of places in tests where we had duplicate code to avoid circular dependencies. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description:
This PR migrates the oidcauthextension component from the Collector core repository to the Collector contrib repository.
This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.
Link to tracking Issue:
opentelemetry-collector/#3474
opentelemetry-collector/#3652