-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kafkaexporter from Collector core to Collector contrib #4656
Migrate kafkaexporter from Collector core to Collector contrib #4656
Conversation
Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks! |
3ee8cf2
to
790d406
Compare
2209ae3
to
a5edf06
Compare
b1d3d1e
to
e5df631
Compare
Please make sure you use the new translator module that you created for opencensus/jaeger if needed instead of the one in collector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend writing a pinned issue describing this migration effort, what/why/how. In particular, I just noticed the approach of copying the opentelemetry-core
repo into internal/core
in advance to then start integrating, which is a neat trick. But documenting this for reviewer benefit and also to keep a record for future archaeology is important. There is #3474, if it's an appropriate issue for this, than I would suggest rewriting the first comment in the issue to include details and the linked issues, etc, presenting it for users. /cc @alolita
It's unfortunate that the commit message in c713647, which is what will show up in git blame for years to come, is basically empty - that one deserved a lot of detail. At the least though GitHub links it to the PR which links to #3474 so we can at least flesh that issue out.
…ry#4656) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description:
This PR migrates the kafkaexporter component from the Collector core repository to the Collector contrib repository.
This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.
Link to tracking Issue:
opentelemetry-collector/#3474
opentelemetry-collector/#3649