Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Relic exporter updates. #4278

Merged

Conversation

a-feld
Copy link
Member

@a-feld a-feld commented Jul 20, 2021

Description:

This PR includes the following updates to the New Relic collector:

Improvements

  • Requests are now retry-able via configuration option (defaults to retries enabled). Permanent errors are not retried
  • The exporter monitoring metrics now include an untagged summary metric for ease of use
  • Improved error logging to include URLs that fail to post messages to New Relic

Bugfix

  • Configuration unmarshalling did not allow timeout value to be set to 0 in the endpoint specific section
  • Request cancellation was not propagated via context into the http request
  • The queued retry logger is set to a zap.Nop logger as intended

CC @alanwest

@a-feld a-feld force-pushed the newrelic/exporter-updates branch from 5bbe395 to da43bd6 Compare July 20, 2021 01:01
@a-feld a-feld marked this pull request as ready for review July 20, 2021 21:14
@a-feld a-feld requested review from a team and bogdandrutu July 20, 2021 21:14
@a-feld a-feld force-pushed the newrelic/exporter-updates branch from 3b9b4d9 to 3c71b99 Compare July 27, 2021 16:02
@alanwest
Copy link
Member

@tigrannajaryan This PR is ready when you have a chance. Thanks!

@bogdandrutu bogdandrutu merged commit 39d7eb7 into open-telemetry:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants