[extension/jaegerremotesampling] fix: wait for autoUpdateStrategies in Close function #37289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Close function Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
yurishkuro
reviewed
Jan 17, 2025
extension/jaegerremotesampling/internal/source/filesource/filesource.go
Outdated
Show resolved
Hide resolved
yurishkuro
approved these changes
Jan 17, 2025
pjanotti
approved these changes
Jan 21, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…n Close function (open-telemetry#37289) #### Description Add a waitGroup to strategyProvider struct that waits for autoUpdateStrategies in the Close function #### Link to tracking issue Fixes open-telemetry#37275 --------- Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a waitGroup to strategyProvider struct that waits for autoUpdateStrategies in the Close function
Link to tracking issue
Fixes #37275