Add cloudwatch encoding #37222
Open
Add cloudwatch encoding #37222
+1,835
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
57
to
59
| if metric.Unit == "" { | ||
| return false, errors.New("cloudwatch metric is missing unit field") | ||
| } |
There was a problem hiding this comment.
It is my understand that a cloudwatch Unit has a fixed set of values, so it can't just accept any.
Not strictly worth fixing now, but something to call out.
There was a problem hiding this comment.
I have added all the possible valid types. I was a bit hesitant on this, because I am afraid it will require more maintenance, but time will tell.
| @@ -0,0 +1,3 @@ | |||
| status: | |||
| codeowners: | |||
| active: [] | |||
There was a problem hiding this comment.
Please add yourself as a code owner here.
There was a problem hiding this comment.
It still fails since I am not a member. Any idea of the next step?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a cloudwatch encoding extension.
Link to tracking issue
#37113
Testing
There are unit tests for every new coding file.
I have some documents in the directory
testdatato test against them.Documentation
See the README file.