[chore] fix failing syslog load test #37197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
|
@codeboten can you please have a look? |
songy23
approved these changes
Jan 15, 2025
codeboten
approved these changes
Jan 16, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The loadtest is failing due to missing year in the timestamp. The timestamp `Oct 11 22:14:15` was until Oct 10 2024 calculated with the year 2023 (`1697062455000000000`) and since then, it by default takes the year 2024, so it results in the following timestamp `1728684855000000000` and causes the test to fail. Failing run on main: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12757989830/job/35563296082 ## Note failing lint test will be resolved in a separate PR open-telemetry#37194 Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loadtest is failing due to missing year in the timestamp. The timestamp
Oct 11 22:14:15was until Oct 10 2024 calculated with the year 2023 (1697062455000000000) and since then, it by default takes the year 2024, so it results in the following timestamp1728684855000000000and causes the test to fail.Failing run on main: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12757989830/job/35563296082
Note
failing lint test will be resolved in a separate PR #37194