[pkg/ottl] Improve errors for invalid cache access and add option to set context's cache value #37166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to set their values
|
@edmocosta needs |
…lector-contrib into ottl-cache-changes
This reverts commit 862ae51.
|
@edmocosta sorry we reverted the tidylist as it was causing problems. Now we need a rebase |
…lector-contrib into ottl-cache-changes
NP, CI is green now, thanks for handling it. |
TylerHelmuth
approved these changes
Jan 13, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…set context's cache value (open-telemetry#37166) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - Improved error message for higher context `cache` access. Now when users try to configure statements like `set(log.attributes["log_key"], resource.cache["log_key"])`, they will see an error message similar to: ```diff + access to cache must be be performed using the same statement's context, please replace "resource.cache[log_key]" with "log.cache[log_key]"` - invalid argument at position 1: segment "cache" from path "resource.cache[log_key]" is not a valid path nor a valid OTTL keyword for the Resource context - review https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/ottl/contexts/ottlresource to see all valid paths ``` - Added the `WithCache` option to all OTTL transformation contexts. This change allows API consumer to set the initial cache value or share it among different contexts/executions. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Split of open-telemetry#36888 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved error message for higher context
cacheaccess. Now when users try to configure statements likeset(log.attributes["log_key"], resource.cache["log_key"]), they will see an error message similar to:Added the
WithCacheoption to all OTTL transformation contexts. This change allows API consumer to set the initial cache value or share it among different contexts/executions.Link to tracking issue
Split of #36888
Testing
Unit tests