feat: add support for MetricTypeSum #37156
Conversation
| Timestamp: timestamp.FromTime(exemplar.Timestamp().AsTime()), | ||
| } | ||
| } | ||
| // TODO append labels to promExemplar.Labels |
There was a problem hiding this comment.
I tried to implement something similar to the current version, but the type of LabelsRefs([]uint32) is a little different of prompb.Label. Do you have any tip to iterate and append LabelsRefs on exemplar field?
There was a problem hiding this comment.
The addSample function does something similar to what you need to do here:
There was a problem hiding this comment.
Thanks. I'm thinking to solve it in a next PR. Trying to figure out how to make the tests pass now
| dataPoints := metric.Sum().DataPoints() | ||
| if dataPoints.Len() == 0 { | ||
| errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) |
There was a problem hiding this comment.
@dashpole you did a comment here saying to remove the error line. Should I remove it?
There was a problem hiding this comment.
Yes, but please remove it from the gauge case above as well
| dataPoints := metric.Sum().DataPoints() | ||
| if dataPoints.Len() == 0 { | ||
| errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) |
There was a problem hiding this comment.
Yes, but please remove it from the gauge case above as well
| @@ -80,7 +80,12 @@ func (c *prometheusConverterV2) fromMetrics(md pmetric.Metrics, settings Setting | |||
| } | |||
| c.addGaugeNumberDataPoints(dataPoints, resource, settings, promName) | |||
| case pmetric.MetricTypeSum: | |||
| // TODO implement | |||
| dataPoints := metric.Sum().DataPoints() | |||
There was a problem hiding this comment.
If the sum is non-monotonic, we need to emit it as a gauge instead.
| Timestamp: timestamp.FromTime(exemplar.Timestamp().AsTime()), | ||
| } | ||
| } | ||
| // TODO append labels to promExemplar.Labels |
There was a problem hiding this comment.
The addSample function does something similar to what you need to do here:
Description
Prometheus translation rw2 add support for MetricTypeSum.
The current work was inspired by #36353
Link to tracking issue #33661