-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take accessToken from context in signalfxexporter #37102
Open
asreehari-splunk
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
asreehari-splunk:OTL-3132/TakeTokenFromContextSignalFxExp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Take accessToken from context in signalfxexporter #37102
asreehari-splunk
wants to merge
4
commits into
open-telemetry:main
from
asreehari-splunk:OTL-3132/TakeTokenFromContextSignalFxExp
+275
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asreehari-splunk
requested review from
dmitryax,
crobert-1 and
a team
as code owners
January 8, 2025 21:32
Based on the title of this PR starting with |
asreehari-splunk
changed the title
Draft: Take accessToken from context in signalfxexporter
Take accessToken from context in signalfxexporter
Jan 13, 2025
dmitryax
reviewed
Jan 13, 2025
lint and tests are failing |
asreehari-splunk
force-pushed
the
OTL-3132/TakeTokenFromContextSignalFxExp
branch
from
January 14, 2025 18:25
838ebad
to
4a154e3
Compare
@dmitryax ... updated. Lint failure is unrelated to my change. I will look again at the end of this run |
dmitryax
reviewed
Jan 14, 2025
Please rebase |
asreehari-splunk
force-pushed
the
OTL-3132/TakeTokenFromContextSignalFxExp
branch
from
January 14, 2025 23:29
4a154e3
to
7056720
Compare
@asreehari-splunk it needs another rebase unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for deprecating access_token_passthrough from the signalfx receiver and exporter, update the signalfx exporter to taken accessToken from the context
Testing
Documentation