Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take accessToken from context in signalfxexporter #37102

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

asreehari-splunk
Copy link
Contributor

@asreehari-splunk asreehari-splunk commented Jan 8, 2025

Description

In preparation for deprecating access_token_passthrough from the signalfx receiver and exporter, update the signalfx exporter to taken accessToken from the context

Testing

  • Updated unit tests
  • tested end to end with the following setup
    • telemetrygen sending metrics in otlp over grpc with X-Sf-Token header and token
    • otlp receiver with include_metadata set to true
    • batch processor using the X-Sf-Token key to group
    • access_token_passthrough set to true

Documentation

@crobert-1
Copy link
Member

Based on the title of this PR starting with Draft:, I've converted this PR to a draft PR. Feel free to update as you see fit. 👍

@asreehari-splunk asreehari-splunk changed the title Draft: Take accessToken from context in signalfxexporter Take accessToken from context in signalfxexporter Jan 13, 2025
@asreehari-splunk asreehari-splunk marked this pull request as ready for review January 13, 2025 21:40
@dmitryax
Copy link
Member

lint and tests are failing

@asreehari-splunk asreehari-splunk force-pushed the OTL-3132/TakeTokenFromContextSignalFxExp branch from 838ebad to 4a154e3 Compare January 14, 2025 18:25
@asreehari-splunk
Copy link
Contributor Author

@dmitryax ... updated. Lint failure is unrelated to my change. I will look again at the end of this run

@dmitryax
Copy link
Member

Please rebase

@asreehari-splunk asreehari-splunk force-pushed the OTL-3132/TakeTokenFromContextSignalFxExp branch from 4a154e3 to 7056720 Compare January 14, 2025 23:29
@dmitryax
Copy link
Member

@asreehari-splunk it needs another rebase unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants