Fix regex used to match docker SHA256 #37045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
approved these changes
Jan 7, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
#### Description Fix the regex used to match docker SHA256. #### Link to tracking issue Fix open-telemetry#36239 #### Testing Local run of `make` at `internal/docker` - caveat: if some other test code depending on this may fail if it is not using a SHA256 with exactly 64 chars it will be broken by this change. I will add any test fix for any such case detected via CI. #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the regex used to match docker SHA256.
Link to tracking issue
Fix #36239
Testing
Local run of
makeatinternal/docker- caveat: if some other test code depending on this may fail if it is not using a SHA256 with exactly 64 chars it will be broken by this change. I will add any test fix for any such case detected via CI.Documentation
N/A