refactor kubelet client to internal folder #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anuraaga @Aneurysm9 @mxiamxia Could you please take a look? Thanks! |
|
@alolita Here is another PR related to AWS Container Insights |
anuraaga
approved these changes
Jun 2, 2021
mx-psi
reviewed
Jun 3, 2021
mx-psi
approved these changes
Jun 3, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor the logic about kubelet client out of
kubeletstatsreceiverand put it into the internal folder so that other components can reuse it. For example, the upcoming container insight receiver also call kubelet endpoint to obtain the metadata information about pods: #3426 (comment)Link to tracking Issue:
#2307
Testing:
Unit tests