Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Replace usage of internal testdata with core pacakge #36967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore] Replace usage of internal testdata with core pacakge #36967

wants to merge 1 commit into from

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu
[chore] Replace usage of internal testdata with core pacakge
d38e3df 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mx-psi
mx-psi reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a make gotidy went wrong? A lot of go.sum files were deleted on this PR

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@github-actions github-actions bot removed the Stale label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 7, 2025
@andrzej-stencel
Copy link
Member

Putting aside the conflicts with current main branch, after checking out the PR's branch I saw some test failures in the affected exporters:

  • Dataset exporter
  • File exporter
  • Prometheus exporter
  • Prometheus Remote Write exporter
  • ... stopped checking there

I agree with what this PR wants to do, but it seems there's some more work to be done before this can be merged.

@github-actions github-actions bot removed the Stale label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@jmacd jmacd Awaiting requested review from jmacd

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

Assignees

@codeboten codeboten

Labels
connector/count connector/exceptions connector/routing connector/signaltometrics connector/spanmetrics connector/sum exporter/awsemf awsemf exporter exporter/awskinesis exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/datadog Datadog components exporter/dataset exporter/doris exporter/elasticsearch exporter/file exporter/honeycombmarker exporter/loki Loki Exporter exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/rabbitmq exporter/sapm exporter/sentry exporter/signalfx exporter/splunkhec exporter/tencentcloudlogservice exporter/zipkin extension/encoding internal/core internal/filter pkg/resourcetotelemetry pkg/stanza pkg/translator/jaeger pkg/translator/opencensus pkg/translator/prometheus pkg/translator/zipkin processor/attributes Attributes processor processor/logstransform Logs Transform processor processor/resource Resource processor processor/span receiver/aerospike receiver/apache receiver/apachespark receiver/awsxray receiver/bigip receiver/cloudflare receiver/datadog receiver/elasticsearch receiver/filelog receiver/filestats receiver/haproxy receiver/hostmetrics receiver/iis receiver/jaeger receiver/jmx JMX Receiver receiver/journald receiver/libhoney receiver/loki receiver/memcached receiver/mongodb receiver/mongodbatlas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdandrutu @andrzej-stencel @mx-psi @MovieStoreGuy @codeboten