[opampsupervisor] avoid nil pointer access when reporting remote config status #36849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
songy23
approved these changes
Dec 16, 2024
dmitryax
approved these changes
Dec 16, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ig status (open-telemetry#36849) #### Description When working on an unrelated PR I noticed that one of the opamp supervisor e2e tests was randomly failing, due to a nil pointer access - see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647 This PR avoids this by using the `GetConfigHash()` method of the `remoteConfig` instead of directly accessing the `ConfigHash` property. #### Link to tracking issue Fixes open-telemetry#36850 --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
…ig status (open-telemetry#36849) #### Description When working on an unrelated PR I noticed that one of the opamp supervisor e2e tests was randomly failing, due to a nil pointer access - see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647 This PR avoids this by using the `GetConfigHash()` method of the `remoteConfig` instead of directly accessing the `ConfigHash` property. #### Link to tracking issue Fixes open-telemetry#36850 --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…ig status (open-telemetry#36849) #### Description When working on an unrelated PR I noticed that one of the opamp supervisor e2e tests was randomly failing, due to a nil pointer access - see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647 This PR avoids this by using the `GetConfigHash()` method of the `remoteConfig` instead of directly accessing the `ConfigHash` property. #### Link to tracking issue Fixes open-telemetry#36850 --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on an unrelated PR I noticed that one of the opamp supervisor e2e tests was randomly failing, due to a nil pointer access - see https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12350739300/job/34464544343?pr=36844#step:8:647
This PR avoids this by using the
GetConfigHash()method of theremoteConfiginstead of directly accessing theConfigHashproperty.Link to tracking issue
Fixes #36850