[exporter/datadogexporter] Migrating datadog exporter to use aws sdk v2 #36797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZiHaN
commented
Dec 12, 2024
|
@LZiHaN can you fix the merge conflict? Otherwise the tests won't run |
done. |
|
Looks like there are some linting errors, could you take a look at those? |
I’ve addressed the linting errors and tested everything locally. Please feel free to let me know if there’s anything else I should take a look at! |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@LZiHaN please rebase |
ce5d382 to
af0eef3
Compare
done. |
songy23
approved these changes
Jan 8, 2025
|
@mx-psi PTAL |
a8e7e25 to
e456e23
Compare
mx-psi
approved these changes
Jan 10, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…v2 (open-telemetry#36797) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Migrating datadog exporter to use aws sdk v2 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue refer to open-telemetry#36699 <!--Describe what testing was performed and which tests were added.--> #### Testing passes tests. updated mock client implementations to support the new SDK interfaces. <!--Describe the documentation added.--> #### Documentation no need to update. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating datadog exporter to use aws sdk v2
Link to tracking issue
refer to #36699
Testing
passes tests.
updated mock client implementations to support the new SDK interfaces.
Documentation
no need to update.