[pkg/stanza][operators] Retain Operator should proagate unreleated fields of the original log entry #35832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee185e to
5c3ed5a
Compare
djaglowski
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thanks for opening this @SamerJ. I agree we should not drop unrelated parts of the data model.
A followup question this raises for me - Any reason we shouldn't also retain the trace fields (trace ID, span ID, trace flags)? If not, could we broaden this fix to include those?
|
@djaglowski |
c7ba0fb to
4a776ca
Compare
4a776ca to
c4508c4
Compare
djaglowski
approved these changes
Oct 24, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…elds of the original log entry (open-telemetry#35832) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The retain operator should propagate the severity field like it does with timestamps. This fix will ensure that is the case. <!--Describe what testing was performed and which tests were added.--> #### Testing Added UT to cover the use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The retain operator should propagate the severity field like it does with timestamps.
This fix will ensure that is the case.
Testing
Added UT to cover the use case.