[connector/otlpjson]: Do not emit empty batches #35827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
approved these changes
Oct 16, 2024
VihasMakwana
approved these changes
Oct 16, 2024
djaglowski
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Apologies for not commenting sooner, but this implementation highlighted the actual problem for me. Please see #35738 (comment)
bogdandrutu
reviewed
Oct 24, 2024
| err = c.tracesConsumer.ConsumeTraces(ctx, t) | ||
| if err != nil { | ||
| c.logger.Error("could not consume traces from otlp json", zap.Error(err)) | ||
| if t.ResourceSpans().Len() != 0 { |
There was a problem hiding this comment.
Should we call t.SpanCount() instead? https://github.com/open-telemetry/opentelemetry-collector/blob/main/pdata/ptrace/traces.go#L44
djaglowski
reviewed
Oct 28, 2024
ChrsMark
reviewed
Oct 29, 2024
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
ChrsMark
reviewed
Nov 7, 2024
djaglowski
approved these changes
Nov 7, 2024
|
Please fix lint errors |
93e2bac to
7946e54
Compare
f10429e to
411c6fb
Compare
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The connector now does not emit empty batches for invalid otlp payload and throws an error instead. Approach discussed here open-telemetry#35738 (comment) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35738 and open-telemetry#35739 <!--Describe what testing was performed and which tests were added.--> #### Testing Manual Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The connector now does not emit empty batches for invalid otlp payload and throws an error instead. Approach discussed here open-telemetry#35738 (comment) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35738 and open-telemetry#35739 <!--Describe what testing was performed and which tests were added.--> #### Testing Manual Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The connector now does not emit empty batches for invalid otlp payload and throws an error instead. Approach discussed here #35738 (comment)
Link to tracking issue
Fixes #35738 and #35739
Testing
Manual Testing
Documentation