telemetrygen: wire up InsecureSkipVerify #35735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag wasn't being used.
axw
commented
Oct 11, 2024
| @@ -82,7 +67,6 @@ func GetTLSCredentialsForHTTPExporter(caFile string, cAuth ClientAuth) (*tls.Con | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| tlsCfg.ClientAuth = tls.RequireAndVerifyClientCert | |||
There was a problem hiding this comment.
Note the reviewer: this change is an incidental cleanup. ClientAuth is irrelevant here, it's only relevant for TLS servers.
mx-psi
approved these changes
Oct 11, 2024
codeboten
approved these changes
Oct 11, 2024
jmichalek132
added a commit
to jmichalek132/opentelemetry-collector-contrib
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com> Fix codeowners (open-telemetry#35754) Fix the allowlist to match memberships. telemetrygen: wire up InsecureSkipVerify (open-telemetry#35735) Thread the InsecureSkipVerify config through properly, so the relevant `tls.Config` struct field is set. Previously, The `--otlp-insecure-skip-verify` flag wasn't effective. I feel like we'd be better off using https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/exporters/autoexport and configuring these things with environment variables, instead of defining flags. I will open an issue for that. None I have added a test that shows the HTTP exporter honours the Insecure, InsecureSkipVerify, and CaFile config fields. I have not done the same for gRPC due to lack of time - this can be done as a followup. OTOH the logic for HTTP & gRPC exporter options shares more now, so the HTTP path tests a fair bit of what gRPC will do anyway.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description Thread the InsecureSkipVerify config through properly, so the relevant `tls.Config` struct field is set. Previously, The `--otlp-insecure-skip-verify` flag wasn't effective. I feel like we'd be better off using https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/exporters/autoexport and configuring these things with environment variables, instead of defining flags. I will open an issue for that. #### Link to tracking issue None #### Testing I have added a test that shows the HTTP exporter honours the Insecure, InsecureSkipVerify, and CaFile config fields. I have not done the same for gRPC due to lack of time - this can be done as a followup. OTOH the logic for HTTP & gRPC exporter options shares more now, so the HTTP path tests a fair bit of what gRPC will do anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thread the InsecureSkipVerify config through properly, so the relevant
tls.Configstruct field is set. Previously, The--otlp-insecure-skip-verifyflag wasn't effective.I feel like we'd be better off using https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/exporters/autoexport and configuring these things with environment variables, instead of defining flags. I will open an issue for that.
Link to tracking issue
None
Testing
I have added a test that shows the HTTP exporter honours the Insecure, InsecureSkipVerify, and CaFile config fields.
I have not done the same for gRPC due to lack of time - this can be done as a followup. OTOH the logic for HTTP & gRPC exporter options shares more now, so the HTTP path tests a fair bit of what gRPC will do anyway.