Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix: Fix flaky logdedupprocessor tests #35719

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

colelaven
Copy link
Contributor

Description

Fixes flaky tests in logdedupprocessor that were failing due to nondeterministic ordering of log records. Those tests now ignore log record order when comparing logs.

Testing

Ran the fixed tests 200+ times without fail.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 9, 2024
@djaglowski djaglowski changed the title Fix: Fix flaky logdedupprocessor tests [chore] Fix: Fix flaky logdedupprocessor tests Oct 9, 2024
@codeboten codeboten merged commit 5219b85 into open-telemetry:main Oct 9, 2024
162 of 163 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
@djaglowski djaglowski deleted the fix-logdedup-tests branch October 9, 2024 15:46
jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this pull request Oct 10, 2024
#### Description
Fixes flaky tests in logdedupprocessor that were failing due to
nondeterministic ordering of log records. Those tests now ignore log
record order when comparing logs.

#### Testing
Ran the fixed tests 200+ times without fail.
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
#### Description
Fixes flaky tests in logdedupprocessor that were failing due to
nondeterministic ordering of log records. Those tests now ignore log
record order when comparing logs.

#### Testing
Ran the fixed tests 200+ times without fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/logdedup Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants