Add the tidying back for otelcontribcol but only on the release thingie #35609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
Oct 4, 2024
andrzej-stencel
approved these changes
Oct 4, 2024
|
Okay, I didn't realize before but this can be tested in my fork, here is a test run https://github.com/mx-psi/opentelemetry-collector-contrib/actions/runs/11179235444 |
|
Okay, the action pushed the branch and it failed to open the PR (which is to be expected given that I don't have a github token in my fork). Merging |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ie (open-telemetry#35609) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The change in open-telemetry#35608 was too aggressive, this reverts the changes in release-prepare-release.sh
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…ie (open-telemetry#35609) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The change in open-telemetry#35608 was too aggressive, this reverts the changes in release-prepare-release.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in #35608 was too aggressive, this reverts the changes in release-prepare-release.sh