Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of manually creating struct #35545

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Oct 2, 2024

Description:
This PR makes usage of NewDefaultClientConfig instead of manually creating the confighttp.ClientConfig struct.

Link to tracking Issue: #35457

…nually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr
Copy link
Member Author

mackjmr commented Oct 15, 2024

@dmitryax @atoulme can you please take a look ?

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Oct 20, 2024
@mackjmr
Copy link
Member Author

mackjmr commented Oct 28, 2024

@atoulme @dmitryax are we good to merge this ?

@andrzej-stencel andrzej-stencel merged commit c40c6a6 into open-telemetry:main Oct 30, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this pull request Nov 12, 2024
…nually creating struct (open-telemetry#35545)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…nually creating struct (open-telemetry#35545)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/splunkhec ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants