[datadogexporter] Deduplicate hosts for which we send running metrics #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
approved these changes
May 26, 2021
|
lint job is failing for an unrelated reason (also failing on main) edit: opened #3540 to fix it. edit 2: fixed |
bogdandrutu
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deduplicate the hostnames for
otel.datadog_exporter.*.runningmetrics so that we don't send them more than once for a given hostname.This could cause issues when having the same hostname for many payloads.
Link to tracking Issue: n/a
Testing: Amended unit tests to check that we are not sending duplicates
cc @KSerrania @ericmustin to review